Skip to content

feat(i18n): add Charter/Spectrum to the ISP presets - #801

Merged
itsDNNS merged 1 commit into
itsDNNS:mainfrom
s0kil:feat/isp-preset-spectrum
Aug 18, 2026
Merged

feat(i18n): add Charter/Spectrum to the ISP presets#801
itsDNNS merged 1 commit into
itsDNNS:mainfrom
s0kil:feat/isp-preset-spectrum

Conversation

@s0kil

@s0kil s0kil commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds Charter/Spectrum to the isp_options preset list in Settings → Connection.

Spectrum is the second-largest US cable ISP. The list already carries Comcast/Xfinity, so this follows the same Parent/Brand naming and sits directly after it.

     "Wilhelm.tel",
-    "Comcast/Xfinity"
+    "Comcast/Xfinity",
+    "Charter/Spectrum"

Notes

  • Applied to all 24 core locales, since isp_options is provider names rather than translated copy. The two locales that carry their own regional list keep it — es stays Vodafone, Euskaltel, R, Telecable, … and fr stays SFR, …, each simply gaining the new entry.
  • python scripts/i18n_check.py --validate passes: All 69 language file(s) are in sync with en.json.
  • Users can already reach this via the "Other" free-text field, so this only saves a manual entry for a large provider — happy to drop it if the preset list is meant to stay German-market-focused.

Separate from #800 (SB8200 CBN driver) to keep that PR to one change. Opened without a prior issue, so happy to move it to a discussion or have it closed.

@itsDNNS
itsDNNS force-pushed the feat/isp-preset-spectrum branch from 44e43ba to a70f15a Compare August 18, 2026 07:43
Spectrum is the second US provider in the list after Comcast/Xfinity and
follows the same parent/brand naming. Applied to all 24 core locales; the
list is shared verbatim across them.
@itsDNNS
itsDNNS force-pushed the feat/isp-preset-spectrum branch from a70f15a to fe36542 Compare August 18, 2026 07:46
@itsDNNS
itsDNNS merged commit 1300bfe into itsDNNS:main Aug 18, 2026
11 checks passed
@s0kil
s0kil deleted the feat/isp-preset-spectrum branch August 18, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants