Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Security Headers #4143

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Add missing Security Headers #4143

merged 2 commits into from
Nov 29, 2022

Conversation

yathomasi
Copy link
Contributor

@yathomasi yathomasi commented Nov 29, 2022

@yathomasi yathomasi self-assigned this Nov 29, 2022
@shcheklein shcheklein temporarily deployed to dvc-org-security-header-jrpdcu November 29, 2022 11:22 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2022

ca11d34

Link Check Report

There were no links to check!

@yathomasi yathomasi marked this pull request as ready for review November 29, 2022 11:37
@yathomasi yathomasi requested a review from a team as a code owner November 29, 2022 11:37
Comment on lines +6 to +12
const helmetOptions = {
contentSecurityPolicy: {
directives: {
frameSrc: ['https://embed.testimonial.to']
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to remember to move this when we do #3898

@rogermparent rogermparent merged commit ca11d34 into main Nov 29, 2022
@rogermparent rogermparent deleted the security-headers branch November 29, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants