-
-
Notifications
You must be signed in to change notification settings - Fork 321
Refactor to allow delegating all invocations to wrapper from vault #17514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ter required to proxy with encryption.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request refactors upload and directory creation features to allow delegating all invocations from wrapper features to the underlying vault implementation. The main changes involve updating method signatures to accept writer/write parameters and removing internal writer references.
- Updated method signatures for
features()
,upload()
,mkdir()
, andtouch()
to accept additional parameters - Removed internal writer initialization and management from upload services
- Modified test cases to provide writer instances explicitly
Reviewed Changes
Copilot reviewed 300 out of 723 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
EUE module files | Updated upload services to accept writer parameters and modified touch/directory features to accept writer instances |
Dropbox module files | Updated upload, touch, directory, and delete features with new method signatures and removed internal writer management |
Dracoon module files | Modified upload services, touch, directory, and delete features to accept writer parameters |
Deepbox module files | Updated touch and directory features to accept writer instances |
Ctera module files | Modified touch feature to accept session parameter instead of writer |
Cryptomator module files | Updated various crypto features to accept additional parameters for delegation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
c802a18
to
d82b3ee
Compare
Superseded by #17535. |
No description provided.