Skip to content

Conversation

dkocher
Copy link
Contributor

@dkocher dkocher commented Sep 25, 2025

No description provided.

@dkocher dkocher added this to the 9.3 milestone Sep 25, 2025
@dkocher dkocher self-assigned this Sep 25, 2025
@dkocher dkocher requested a review from a team as a code owner September 25, 2025 19:33
@dkocher dkocher added the cryptomator Cryptomator Vault label Sep 25, 2025
@dkocher dkocher requested review from ylangisc and Copilot September 25, 2025 19:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors upload and directory creation features to allow delegating all invocations from wrapper features to the underlying vault implementation. The main changes involve updating method signatures to accept writer/write parameters and removing internal writer references.

  • Updated method signatures for features(), upload(), mkdir(), and touch() to accept additional parameters
  • Removed internal writer initialization and management from upload services
  • Modified test cases to provide writer instances explicitly

Reviewed Changes

Copilot reviewed 300 out of 723 changed files in this pull request and generated no comments.

Show a summary per file
File Description
EUE module files Updated upload services to accept writer parameters and modified touch/directory features to accept writer instances
Dropbox module files Updated upload, touch, directory, and delete features with new method signatures and removed internal writer management
Dracoon module files Modified upload services, touch, directory, and delete features to accept writer parameters
Deepbox module files Updated touch and directory features to accept writer instances
Ctera module files Modified touch feature to accept session parameter instead of writer
Cryptomator module files Updated various crypto features to accept additional parameters for delegation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dkocher dkocher marked this pull request as draft September 26, 2025 08:31
@dkocher dkocher marked this pull request as ready for review September 26, 2025 09:02
@dkocher dkocher force-pushed the feature/KATTA-vaultregistry branch from c802a18 to d82b3ee Compare September 26, 2025 15:45
@dkocher dkocher marked this pull request as draft October 1, 2025 11:33
@dkocher
Copy link
Contributor Author

dkocher commented Oct 3, 2025

Superseded by #17535.

@dkocher dkocher closed this Oct 3, 2025
@dkocher dkocher removed this from the 9.3 milestone Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cryptomator Cryptomator Vault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants