Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any upload is better than no upload #242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

duzda
Copy link

@duzda duzda commented Aug 29, 2022

Basically, if all the uploads get filtered, then the user can't download the app, this PR changes the behavior and if there are no valid uploads left, then it allows the user to choose any of the uploads. How could this be helpful? In my case, I commonly use itch app for game jams, but if the dev doesn't select the appropriate platform, suddenly his game is not downloadable by itch.

This PR changes behavior from this:
image

To this:
image

However if dev does specify the platform, then no changes are made and user gets shown only the appropriate ones for his OS.
It might be nice to notify the user about the unknown platform in the itch app, I think I can add that later.

@hsandt
Copy link

hsandt commented Nov 28, 2024

Very useful for jam games, where devs tend to upload in a hurry, sometimes not using butler and not benefiting from the automated build name detection; and for Renpy games where the "pc" build is for Windows and Linux but that's not obvious from the name, so even butler misses that and cannot automatically tag the game (maybe for Windows, I don't remember, but definitely not Linux).

Still needed to comment on a game page to tell dev to properly tag their builds today.

Workaround: open page in web browser and manually download the build, but more cumbersome (and esp. feels weird as itch app is already a web app)

P.S.: I just realized this PR has no associated issue (#2929 being slightly different), so I have no choice but to comment here although PR thread is usually for comments about the PR itself. If it's a problem I can continue talking on #2929 instead, but really I probably don't have anything more to say at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants