Open
Conversation
gyim1345
approved these changes
Jan 1, 2021
Collaborator
gyim1345
left a comment
gyim1345
left a comment
There was a problem hiding this comment.
코드 엄청 깔끔하게 짜셨네요! 수고하셨습니다!
gyim1345
reviewed
Jan 1, 2021
Collaborator
There was a problem hiding this comment.
data 랑 value가 같은 type?것?을 가르키는 것 같은데 혹시 연관이 잘 안되는(저만 그렇게 느낄수도??ㅋㅋ) 두 변수 이름을 쓰시는 이유가 있을까요?
daadaadaah
approved these changes
Jan 3, 2021
Collaborator
daadaadaah
left a comment
daadaadaah
left a comment
There was a problem hiding this comment.
이번 코드 너무 읽기 편했습니다 👍👍👍👍👍
깔끔한 코드 굿굿!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.