Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edited base64 decode command #15691

Merged
merged 2 commits into from
Sep 15, 2024
Merged

edited base64 decode command #15691

merged 2 commits into from
Sep 15, 2024

Conversation

find-arka
Copy link
Contributor

Description

Edited since the decode it's failing with message base64: invalid argument - It works alright when we remove the trailing -

Screenshot 2024-09-14 at 4 06 56 PM

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

Edited sincle it's failing with message-
base64: invalid argument -
@find-arka find-arka requested a review from a team as a code owner September 14, 2024 20:07
@istio-policy-bot
Copy link

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been a while since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, our style guidelines,
    and the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be built with
    a full copy of the istio.io website. You can find this preview by clicking on
    the Details link next to the deploy/netlify entry in the status section of this
    page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation
    is top-notch. We do spell checking, sanitize the Markdown, ensure all hyperlinks point to a
    valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
    lint_istio.io entry in the status section. Click on the Details link to get a list of the
    problems with your PR. Fix those problems and push an update; this will automatically re-run the
    tests. Hopefully this time everything will be perfect!

  • Once your changes are accepted and merged into the repository, they will initially show up
    on https://preliminary.istio.io. The changes will be published to https://istio.io
    the next time we do a major release (which typically happens every 3 months or so).
    To publish them sooner, add a cherrypick/release-x.xx label, where x.xx is the current
    release of Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 14, 2024
@dhawton dhawton added the cherrypick/release-1.23 Set this label on a PR to auto-merge it to the release-1.23 branch label Sep 15, 2024
@istio-testing istio-testing merged commit 788b8b7 into istio:master Sep 15, 2024
13 checks passed
@istio-testing
Copy link
Contributor

In response to a cherrypick label: #15691 failed to apply on top of branch "release-1.23":

Applying: edited base64 decode command
Applying: make gen changes
Using index info to reconstruct a base tree...
M	content/en/docs/tasks/security/authorization/authz-jwt/snips.sh
Falling back to patching base and 3-way merge...
Auto-merging content/en/docs/tasks/security/authorization/authz-jwt/snips.sh
CONFLICT (content): Merge conflict in content/en/docs/tasks/security/authorization/authz-jwt/snips.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 make gen changes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

@istio-testing
Copy link
Contributor

In response to a cherrypick label: new issue created for failed cherrypick: #15692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick/release-1.23 Set this label on a PR to auto-merge it to the release-1.23 branch kind/docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants