Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context restoring #27

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 40 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ Here is the list of available actions:
- `Compose(*actions)` - composition of several puppeteer action
- `Scroll(selector, wait_options)` - scroll page
- `Screenshot(options)` - take screenshot
- `RecaptchaSolver(solve_recaptcha, close_on_empty)` - find or solve recaptcha on page
- `Har()` - to get the HAR file, pass the `har_recording=True` argument to `PuppeteerRequest` at the start of execution.
- `FillForm(input_mapping, submit_button)` - to fill out and submit forms on page.
- `RecaptchaSolver(solve_recaptcha)` - find or solve recaptcha on page
- `CustomJsAction(js_function)` - evaluate JS function on page

Available options essentially mirror [service](https://github.com/ispras/scrapy-puppeteer-service) method parameters, which in turn mirror puppeteer API functions to some extent.
Expand Down Expand Up @@ -166,6 +166,45 @@ and will notify you about number of found captchas on the page.
If you don't want the middleware to work on specific request you may provide special meta key: `'dont_recaptcha': True`.
In this case RecaptchaMiddleware will just skip the request.

## Automatic context restoring

Sometimes you may receive responses with status 422 (Unprocessable Entity).
This means the scrapy-puppeteer-services struggled to find provided context or page in its memory.
In such situations you can use this middleware to restore these contexts.

Enabling the middleware:
```Python
DOWNLOADER_MIDDLEWARES = { # Strict order of middlewares
# 'scrapypuppeteer.middleware.PuppeteerRecaptchaDownloaderMiddleware': 1040, # You may also use recaptcha middleware
'scrapypuppeteer.middleware.PuppeteerContextRestoreDownloaderMiddleware': 1041,
'scrapypuppeteer.middleware.PuppeteerServiceDownloaderMiddleware': 1042,
}
```

Settings of the middleware:
```Python
N_RETRY_RESTORING = 3 # Number of tries to restore a context
RESTORING_LENGTH = 2 # Number of restorable requests in a sequence
```

Currently, the middleware can only restart from the beginning of request-response sequence.
You can start this sequence with `recover_context` meta-key, just provide `True` value.
Example:
```Python
...
yield PuppeteerRequest(
url,
callback=self.click_on_navigation,
errback=self.errback,
close_page=False,
meta={'recover_context': True}
)
...
```

Also, you can see `dead_context` spider and try to enable `PuppeteerContextRestoreDownloaderMiddleware` in its `custom_settings`
to see the working middleware.

## TODO

- [x] skeleton that could handle goto, click, scroll, and actions
Expand Down
74 changes: 74 additions & 0 deletions examples/spiders/dead_context.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
from asyncio import sleep

import scrapy
from twisted.python.failure import Failure

from scrapypuppeteer import PuppeteerRequest, PuppeteerResponse
from scrapypuppeteer.actions import Click, GoTo


class DeadContextSpider(scrapy.Spider):
custom_settings = {
"TWISTED_REACTOR": "twisted.internet.asyncioreactor.AsyncioSelectorReactor",
"DOWNLOADER_MIDDLEWARES": {
"scrapypuppeteer.middleware.PuppeteerContextRestoreDownloaderMiddleware": 1041,
"scrapypuppeteer.middleware.PuppeteerServiceDownloaderMiddleware": 1042,
},
"N_RETRY_RESTORING": 3,
"RESTORING_LENGTH": 2,
}
name = "dead_context"

def start_requests(self):
urls = [
"https://www.google.com/recaptcha/api2/demo",
"https://scrapy.org",
"https://pptr.dev",
]

for url in urls:
yield PuppeteerRequest(
url,
callback=self.click_on_navigation,
errback=self.errback,
close_page=False,
meta={"recover_context": True},
)

async def click_on_navigation(self, response: PuppeteerResponse):
await sleep(4)

click = Click(
"#__docusaurus > nav > div.navbar__inner > div:nth-child(1) > a:nth-child(3)"
)
yield response.follow(
click, callback=self.click_back, errback=self.errback, close_page=False
)

async def click_back(self, response: PuppeteerResponse):
await sleep(4)

click = Click(
"#__docusaurus > nav > div.navbar__inner > div:nth-child(1) > a.navbar__brand > b"
)
yield response.follow(
click, callback=self.goto_api, errback=self.errback, close_page=False
)

async def goto_api(self, response):
await sleep(4)

yield response.follow(
GoTo("api/puppeteer.puppeteernode"),
callback=self.empty_action,
errback=self.errback,
close_page=False,
)

@staticmethod
async def empty_action(response, **kwargs):
await sleep(4)

@staticmethod
def errback(failure: Failure):
print(failure)
Loading
Loading