Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLDR-748 structure pattern #483

Merged
merged 9 commits into from
Sep 2, 2024
Merged

TLDR-748 structure pattern #483

merged 9 commits into from
Sep 2, 2024

Conversation

NastyBoget
Copy link
Collaborator

@NastyBoget NastyBoget commented Aug 14, 2024 •
edited
Loading

  • removed regular expression usage from readers;
  • removed creation of raw_text lines from readers, use unknown type instead;
  • added patterns for structure extraction;
  • rewrote DefaultStructureExtractor using patterns;
  • added new API parameter patterns;
  • added API and unit tests for patterns;
  • added documentation for classes;
  • added tutorial how to use patterns;
  • added links correctness checking in docs and fixed docs bugs.

@NastyBoget NastyBoget self-assigned this Aug 14, 2024
@NastyBoget NastyBoget force-pushed the TLDR-748_structure_pattern branch 2 times, most recently from d9b385c to 142aa81 Compare August 14, 2024 13:37
@NastyBoget NastyBoget added the enhancement New feature or request label Aug 15, 2024
Base automatically changed from develop to master August 16, 2024 13:26
@NastyBoget NastyBoget changed the base branch from master to develop August 16, 2024 13:38
@NastyBoget NastyBoget force-pushed the TLDR-748_structure_pattern branch from 3322468 to c505eaa Compare August 16, 2024 13:46
@NastyBoget NastyBoget force-pushed the TLDR-748_structure_pattern branch from 4ee4791 to 2a91bd3 Compare August 27, 2024 07:58
@NastyBoget NastyBoget added the documentation Improvements or additions to documentation label Aug 29, 2024
@ispras ispras deleted a comment from oksidgy Aug 30, 2024
@ispras ispras deleted a comment from oksidgy Aug 30, 2024
@NastyBoget NastyBoget force-pushed the TLDR-748_structure_pattern branch from b6617d9 to 08b9c21 Compare September 2, 2024 09:35
@NastyBoget NastyBoget force-pushed the TLDR-748_structure_pattern branch from 08b9c21 to af39a81 Compare September 2, 2024 09:56
@oksidgy oksidgy requested review from oksidgy and removed request for dronperminov September 2, 2024 11:24
@oksidgy oksidgy merged commit cbaa665 into develop Sep 2, 2024
3 checks passed
@oksidgy oksidgy deleted the TLDR-748_structure_pattern branch September 2, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avtomatik avtomatik avtomatik left review comments

@oksidgy oksidgy oksidgy approved these changes

Assignees

@NastyBoget NastyBoget

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NastyBoget @oksidgy @avtomatik