Update contributing guide #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SweetVishnya
approved these changes
Dec 8, 2023
hkctkuy
force-pushed
the
update_contributing
branch
from
022bdd1 to
565cd07
Compare
anfedotoff
requested changes
Dec 8, 2023
| @@ -220,7 +220,7 @@ Please follow the next recommendations for your pull requests: | |||
| - compile with *stable* rust | |||
| - use `cargo fmt` | |||
| - check the output of `cargo clippy --all-features --all --tests` | |||
| - run tests `cargo test` | |||
| - run tests `cargo test --lib -- --test-threads 1` and `cargo test --package casr` | |||
There was a problem hiding this comment.
It's better to fix concurrency.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #189 +/- ##
==========================================
- Coverage 62.54% 61.98% -0.57%
==========================================
Files 30 30
Lines 7041 7102 +61
==========================================
- Hits 4404 4402 -2
- Misses 2637 2700 +63 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.