Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance: Added bpf-hostlegacyrouting option #174

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

PhilipSchmid
Copy link
Collaborator

@PhilipSchmid PhilipSchmid commented Jan 6, 2025

Added a configurable bpf-hostlegacyrouting option to the conformance tests as Cilium 1.16.5+ introduced a breaking change for Talos 'forwardKubeDNSToHost'. See cilium/cilium#35098 for more details.

I've explicitly set bpf-hostlegacyrouting: true for all test cases. For the KPR ones to fix the issue mentioned above, and for the others as it's disabled anyway in their case (because of enabled IPsec and KPR being disabled). Please look at the relevant code here.

@PhilipSchmid PhilipSchmid self-assigned this Jan 6, 2025
Added a configurable bpf-hostlegacyrouting option to the conformance
tests as Cilium 1.16.5+ introduced a breaking change for Talos
'forwardKubeDNSToHost'. See cilium/cilium#35098
for more details.

Signed-off-by: Philip Schmid <[email protected]>
@PhilipSchmid PhilipSchmid force-pushed the pr/philip/bpf_hostlegacyrouting_for_kpr branch from ff76a34 to 2faca6e Compare January 6, 2025 16:19
Copy link

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@PhilipSchmid PhilipSchmid merged commit c26c947 into main Jan 7, 2025
45 checks passed
@PhilipSchmid PhilipSchmid deleted the pr/philip/bpf_hostlegacyrouting_for_kpr branch January 7, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants