-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IDB interface #127
base: main
Are you sure you want to change the base?
Fix IDB interface #127
Conversation
Thanks for the PR, unfortunately I'm not able to merge because test are failing, and I don't know how to fix them. |
I just saw your bug report for karma-sauce-launcher. It should be the same issue. Just added additional info others to help debug:
|
I tried to push to force re-run the tests. But it seems that you didn't allow edits to your PR. |
I'm not sure, I can't push:
Maybe I do something wrong, or maybe because you use the main branch. Can you run? git rebase -i 9eb71923ed02a2f23d81194feb9e99ef713f5f1b To change the hash and force push? |
I tried rebase, it has no effect because my change was actually based on |
I will try cherry-picking your commits. |
The failing tests are probably because of old version of the browsers that are not supported by SauceLabs anymore. They need to be updated to latest supported versions. The change will need to wait for the tests to be fixed, since releases happen automatically after tests passes. |
Fixing #126
constructor(...)
method from the interface. When user provides a customdb
instance, the constructor is never invoked by the lightning-fs so constraining it in the interface is unnecessary. Please confirm this though. In addition, if we want to constrain the constructor interface, (for whatever reason), a different setup is required. See: https://stackoverflow.com/questions/13407036/how-does-interfaces-with-construct-signatures-workloadFile
toreadFile
, matching implemention.