Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IDB interface #127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix IDB interface #127

wants to merge 1 commit into from

Conversation

chuanqisun
Copy link

@chuanqisun chuanqisun commented Jun 15, 2024

Fixing #126

  1. Removed the constructor(...) method from the interface. When user provides a custom db instance, the constructor is never invoked by the lightning-fs so constraining it in the interface is unnecessary. Please confirm this though. In addition, if we want to constrain the constructor interface, (for whatever reason), a different setup is required. See: https://stackoverflow.com/questions/13407036/how-does-interfaces-with-construct-signatures-work
  2. Renamed loadFile to readFile, matching implemention.

@jcubic
Copy link
Contributor

jcubic commented Jun 16, 2024

Thanks for the PR, unfortunately I'm not able to merge because test are failing, and I don't know how to fix them.

@chuanqisun
Copy link
Author

chuanqisun commented Jun 16, 2024

I just saw your bug report for karma-sauce-launcher. It should be the same issue. Just added additional info others to help debug:

  1. The failing test was a headless browser test that is supposed to run on Edge v79 on a remote testing service provider (SauceLab).
  2. The failure appeared to be a network issue. The remote testing service (SauceLab) refused our network connection, we have retried twice and still no connection. The actual test was never run.
  3. Tests against other browsers all passed.
  4. Because the issue is not related to my change, any future PRs might be blocked by the same issue.

@jcubic
Copy link
Contributor

jcubic commented Mar 8, 2025

I tried to push to force re-run the tests. But it seems that you didn't allow edits to your PR.

@chuanqisun
Copy link
Author

I'm sorry, I've already checked the "Allow edits" box. Is there something else I can do to unblock you?
image

@jcubic
Copy link
Contributor

jcubic commented Mar 10, 2025

I'm not sure, I can't push:

 ! [remote rejected] chuanqisun/main -> chuanqisun/main (permission denied)
error: failed to push some refs to 'github.com:chuanqisun/lightning-fs.git'

Maybe I do something wrong, or maybe because you use the main branch.

Can you run?

git rebase -i 9eb71923ed02a2f23d81194feb9e99ef713f5f1b

To change the hash and force push?

@chuanqisun
Copy link
Author

chuanqisun commented Mar 12, 2025

I tried rebase, it has no effect because my change was actually based on 9eb71923ed02a2f23d81194feb9e99ef713f5f1b. If you want to do it the old school way, here is the patch file you can manually apply into your own branch.

2025-03-12-ts-interface-fix.patch

@jcubic
Copy link
Contributor

jcubic commented Mar 13, 2025

I will try cherry-picking your commits.

@jcubic
Copy link
Contributor

jcubic commented Mar 18, 2025

The failing tests are probably because of old version of the browsers that are not supported by SauceLabs anymore. They need to be updated to latest supported versions.

The change will need to wait for the tests to be fixed, since releases happen automatically after tests passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants