Fix association table xpath for custom Literal generators. #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aindlq
commented
Apr 1, 2024
aindlq
commented
- small refactoring, to remove duplicated code
- simplify Literal xpath generation for the association table
- add unit test for association table generation
1. small refactoring, to remove duplicated code 2. simplify Literal xpath generation for the association table 3. add unit test for association table generation Signed-off-by: Artem Kozlov <[email protected]>
aindlq
force-pushed
the
association-table-tests
branch
from
07457b7 to
55432e9
Compare
Support function calls, relative path and indexed access. Update unit test accordingly. Signed-off-by: Artem Kozlov <[email protected]>
Author
|
Association table didn't generated proper xpath when it already contained indexed access or relative path. I fixed that and added a unit test for that. |
XPath generation was messing with paths inside function calls. With this change we add [1] only to path segments that are not inside function calls. Signed-off-by: Artem Kozlov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.