Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asiolink for boost 1.87 #143

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

q66
Copy link
Contributor

@q66 q66 commented Dec 15, 2024

i'm going through boost 1.87 update in chimera linux and kea was one of the things failing to build due to removal of deprecated api from asio, so here are fixes

Copy link
Collaborator

@fxdupont fxdupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works it should be better to include the asiolink/io_service.h file in iface_mgr.cc.

BTW I am afraid that some unit test and hook file need update too.

@q66
Copy link
Contributor Author

q66 commented Dec 19, 2024

hm, i'm not sure what that means? oh, nevermind, the header contains a typedef

@fxdupont fxdupont merged commit c0ff7cb into isc-projects:master Dec 19, 2024
2 checks passed
@fxdupont
Copy link
Collaborator

Integrated into Kea gitlab issue 3696 which should be very likely in the next release 2.7.6 at the end of January 2025.

@andrei-pavel
Copy link
Collaborator

@q66, would you like to be commended in the AUTHORS file for this contribution? And if so, should it be under name q66?

@fxdupont
Copy link
Collaborator

Or in the ChangeLog entry? In anycase your name is needed...

@q66
Copy link
Contributor Author

q66 commented Jan 15, 2025

i don't really mind either way but if you do, yes that's fine

@fxdupont
Copy link
Collaborator

We need a qualified identity (of any type e.g. full name, email, url, etc) for citing you as a contributor.

@tomaszmrugalski
Copy link
Member

We need a qualified identity (of any type e.g. full name, email, url, etc) for citing you as a contributor.

Not really. q66 would be probably the shortest attribution and most cryptic so far, but I will do.

Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants