Skip to content

feat: enhance MCP tool name validation with comprehensive pattern detection #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
isadeks wants to merge 83 commits into
base: main
Choose a base branch
from

Merge branch 'main' into issue-616-tool-naming-validation

f71d020
Select commit
Loading
Failed to load commit list.
Draft

feat: enhance MCP tool name validation with comprehensive pattern detection #1

Merge branch 'main' into issue-616-tool-naming-validation
f71d020
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Semgrep OSS succeeded Mar 4, 2026 in 5s

5 new alerts

New alerts in code changed by this pull request

  • 5 warnings

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 86 in src/aws-diagram-mcp-server/awslabs/aws_diagram_mcp_server/diagrams_tools.py

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: python.lang.security.audit.dynamic-urllib-use-detected.dynamic-urllib-use-detected Warning

Detected a dynamic value being used with urllib. urllib supports 'file://' schemes, so a dynamic value controlled by a malicious actor may allow them to read arbitrary files. Audit uses of urllib calls to ensure user data cannot control the URLs, or consider using the 'requests' library instead.

Check warning on line 447 in src/aws-diagram-mcp-server/awslabs/aws_diagram_mcp_server/diagrams_tools.py

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: python.lang.security.audit.exec-detected.exec-detected Warning

Detected the use of exec(). exec() can be dangerous if used to evaluate dynamic content. If this content can be input from outside the program, this may be a code injection vulnerability. Ensure evaluated content is not definable by external sources.

Check warning on line 463 in src/aws-diagram-mcp-server/awslabs/aws_diagram_mcp_server/diagrams_tools.py

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: python.lang.security.audit.exec-detected.exec-detected Warning

Detected the use of exec(). exec() can be dangerous if used to evaluate dynamic content. If this content can be input from outside the program, this may be a code injection vulnerability. Ensure evaluated content is not definable by external sources.

Check warning on line 383 in src/dynamodb-mcp-server/awslabs/dynamodb_mcp_server/model_validation_utils.py

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: python.lang.security.audit.dynamic-urllib-use-detected.dynamic-urllib-use-detected Warning

Detected a dynamic value being used with urllib. urllib supports 'file://' schemes, so a dynamic value controlled by a malicious actor may allow them to read arbitrary files. Audit uses of urllib calls to ensure user data cannot control the URLs, or consider using the 'requests' library instead.

Check warning on line 78 in src/dynamodb-mcp-server/awslabs/dynamodb_mcp_server/repo_generation_tool/generators/jinja2_generator.py

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: python.flask.security.xss.audit.direct-use-of-jinja2.direct-use-of-jinja2 Warning

Detected direct use of jinja2. If not done properly, this may bypass HTML escaping which opens up the application to cross-site scripting (XSS) vulnerabilities. Prefer using the Flask method 'render_template()' and templates with a '.html' extension in order to prevent XSS.