Open
Conversation
Created Teacher Service
Created Teacher Service
Created Teacher Controller and modifications.
adding update delete and patch
adding exception handling
some refactoring
ahpoise
reviewed
Mar 12, 2026
| Teacher oldTeacher = getTeacherById(id); | ||
| if (name != null) { | ||
| oldTeacher.setName(name); | ||
| } |
There was a problem hiding this comment.
You could use patch here to also update the salary, but that would required you to change in the model from the primitive to the wrapper, double to Double so you could check for null here.
There's nothing wrong, just an input if you wanted to add the salary update also on the patch.
ahpoise
reviewed
Mar 12, 2026
| this.status = status; | ||
| this.error = error; | ||
| this.message = message; | ||
| this.timestamp = LocalDateTime.now(); |
There was a problem hiding this comment.
Both here and on the ValidationErrorResponse you are accepting the timestamp but you are not actually using it.
|
Two small notes. Other than that is a good Ironschool submission. Congrats. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.