Finished project Yunis | Ayhan#74
Open
AyhanAghayev wants to merge 3 commits intoironhack-labs:mainfrom
Open
Conversation
ahpoise
reviewed
Mar 12, 2026
| public void setStudentId(String courseId){ | ||
| this.studentId=studentId; | ||
| } | ||
| public void setName(String studentId){ |
There was a problem hiding this comment.
shouldn't it be String name rather then studentId?
ahpoise
reviewed
Mar 12, 2026
| public Course getCourse(){ | ||
| return course; | ||
| } | ||
| public void setStudentId(String courseId){ |
There was a problem hiding this comment.
shouldn't it be String studentId rather then courseId?
ahpoise
reviewed
Mar 12, 2026
| } | ||
|
|
||
| @PostMapping | ||
| public ResponseEntity<Student> createStudent(@RequestBody String name, String address, String email) { |
There was a problem hiding this comment.
@RequestBody like this won't work.
createStudent(@RequestBody Student student) is the proper way.
The same happens in update.
ahpoise
reviewed
Mar 12, 2026
| } | ||
|
|
||
| @GetMapping("/{courseId}/students") | ||
| public ResponseEntity<List<Student>>getEnrolledStudents(String courseId) { |
ahpoise
reviewed
Mar 12, 2026
| return ResponseEntity.ok(studentEnrolled); | ||
| } | ||
|
|
||
| @GetMapping("/{studentId}/course") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.