Open
Conversation
ahpoise
reviewed
Mar 12, 2026
| public Teacher updatePartially(String id,Teacher teacher){ | ||
| Teacher updatedTeacher = getTeacherById(id); | ||
| if(teacher.getName()!= null) updatedTeacher.setName(teacher.getName()); | ||
| if(teacher.getSalary() != 0) updatedTeacher.setSalary(teacher.getSalary()); |
There was a problem hiding this comment.
teacher.getSalary() != null
You are using correctly the wrapper Double and not the primitive double in your model. Check for null.
If you want to also check for positive values you can do that on validation for example.
ahpoise
reviewed
Mar 12, 2026
| import java.util.List; | ||
|
|
||
| @Service | ||
| @RequestMapping("/student") |
There was a problem hiding this comment.
What is a @RequestMapping doing here in services?
|
Adding exception handling would be good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.