Open
Conversation
* feat: Teacher model is added. * feat: Removed unnecessary spaces.And adding "get id".
* feat: Course model is added. * feat: Course model is added.
* feat: Teacher service is added * feat: Teacher service updated for readability.
* feat: Student service + controller added. Some refactoring is done. * docs: Postman collection added
…ced by contains. (#11)
ahpoise
reviewed
Mar 11, 2026
src/main/java/com/ironhack/controller/advice/GlobalExceptionHandler.java
Outdated
Show resolved
Hide resolved
ahpoise
reviewed
Mar 11, 2026
src/main/java/com/ironhack/controller/advice/GlobalExceptionHandler.java
Outdated
Show resolved
Hide resolved
ahpoise
reviewed
Mar 11, 2026
| Double price, | ||
|
|
||
| @NotNull(message = "Money earned is required") | ||
| @Positive(message = "Money earned must be a positive number") |
There was a problem hiding this comment.
Shouldn't a new course start with money earned as 0?
This could even be removed from the create course, right?
Author
There was a problem hiding this comment.
Tbh if we take into account that this can be internal app, then most possibly courses already exist. In other case, app should include pricing methods and endpoints, mock payment logic to increase moneyEarned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.