Open
Conversation
Done models and corrected id generators
Service classes are finished
created simple menu
…ava-ironschool into menu Created exceptions
Exceptions
Need to push menu in main
…ommand to console
ahpoise
reviewed
Mar 12, 2026
| this.teacherService = teacherService; | ||
| } | ||
| private Map<String, Course> courses = new HashMap<>(); | ||
| private final TeacherService teacherService; |
There was a problem hiding this comment.
You are declaring teacherService two times: one private the other public. What was the objective?
Author
There was a problem hiding this comment.
I removed the duplicate teacherService declaration; the error is fixed. Thanks!
ahpoise
reviewed
Mar 12, 2026
| @Service | ||
| public class StudentService { | ||
| public final CourseService courseService; | ||
| public StudentService(CourseService courseService){ |
There was a problem hiding this comment.
Why is courseService here if you are not using it in the StudentService?
|
I see that you have custom exceptions, why not implement a @ControllerAdvice or a @@RestControllerAdvice? Why didn't you cover put and patch in the controllers? And wh also no validation using @Valid? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.