Skip to content

HomeWork finished#61

Open
ilkinismayilov-905 wants to merge 25 commits intoironhack-labs:mainfrom
ilkinismayilov-905:TaskMain
Open

HomeWork finished#61
ilkinismayilov-905 wants to merge 25 commits intoironhack-labs:mainfrom
ilkinismayilov-905:TaskMain

Conversation

@ilkinismayilov-905
Copy link
Copy Markdown

No description provided.

@ahpoise
Copy link
Copy Markdown

ahpoise commented Mar 11, 2026

  • ResponseEntity on some some controllers, not on all. Check StudentsController.
  • There's no POST mapping on courses and there's no service to create courses.
  • Base path always starts with /api except for students. It will work but it's inconsistent, right?
  • You are creating the students via RequestParams. Is it possible? Yes. It it the desirable pattern? No.
  • Why not handle validation exceptions also? And at least a general catch all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants