-
-
Notifications
You must be signed in to change notification settings - Fork 8
feature: Bump native assets cli and fix bug #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@knopp Hello, can you look this PR? |
Hi, apologize for the delay. Any chance you can upgrade the android project so that we can get the CI to pass? |
I will try |
The windows/android build fails with
I'm guessing it's because the path has 261 characters, which requires windows long path support? But I thought it is enabled in the runner images. |
Does visual studio linker still not support long paths? |
logger: logger, | ||
); | ||
} | ||
// final effectiveBuildMode = release ? BuildMode.release : BuildMode.debug; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is not needed it should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits. Once addressed I think I'll merge this and then figure out how to shorten the build paths so that the build passes on windows.
@@ -135,7 +133,10 @@ class RustBuilder { | |||
final String cratePath; | |||
|
|||
/// Build config provided to the build callback from `native_assets_cli`. | |||
final BuildConfig buildConfig; | |||
|
|||
// final BuildOutputBuilder outputBuilder; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing. If not needed should be removed.
I found general issue about it in Cargo rust-lang/cargo#9770 I also found interesting topic about it here rust-lang/cargo#7986 (comment) I tried reproduce it in my package with your package, but I got error compilation via rustup. Maybe you can do it. I'll try this later. |
You right it's issue related with linker MSVC. I don't know how to resolve it in CI because I didn't work with CI GItlab. I mistakenly thought it was related to |
Hello @knopp!
In this PR I upgraded dependencies for
native_assets_cli: ^0.11.0
and fixed breaking changes.Also I fixed build for macos how you did #17