Support switching between mainnet and testnet#122
Merged
Conversation
dguenther
force-pushed
the
network-switching
branch
2 times, most recently
from
0089ebf to
3e4c53a
Compare
dguenther
force-pushed
the
network-switching
branch
from
3e4c53a to
85aa4d1
Compare
cgjohn
approved these changes
Feb 13, 2025
Contributor
There was a problem hiding this comment.
Looks good! We could try giving cursor an image of the design Skylar has for network switching which could remove the need for the modal currently popping up when clicking change network
Member
Author
|
Oh, he actually had that modal in an older prototype, but maybe he didn't bring it over. I'm down for any design tweaks regardless, I haven't actively styled this page yet! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for switching between mainnet and testnet.
I currently have it re-import all accounts when switching between networks. I modified account import to do nothing if an account with the same public address exists in the database, but this does introduce some edge cases where someone imports the same account with a different name, or same account plus/minus the spend key. Nothing will happen now, where previously we'd throw an error.