Set MLIR_LINK_MLIR_DYLIB to not link shared libMLIR #19613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marbre
changed the title
|
BYO LLVM build status, see https://github.com/iree-org/iree/actions/runs/12638450895. |
ScottTodd
approved these changes
Jan 6, 2025
|
The BYO LLVM workflow went beyond building LLVM and MLIR. Merging therefore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With llvm/llvm-project@10ef20f, support for
MLIR_LINK_MLIR_DYLIBwas introduced. WithLLVM_LINK_LLVM_DYLIBset toONatiree/build_tools/llvm/llvm_config.cmake
Line 30 in cdf24b9
MLIR_LINK_MLIR_DYLIB. This break the BYO LLVM workflow, see #19549, hence, setting toOFF.