Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI - Linux x64 clang BYO LLVM failing during build #19549

Closed
Eliasj42 opened this issue Dec 20, 2024 · 2 comments
Closed

CI - Linux x64 clang BYO LLVM failing during build #19549

Eliasj42 opened this issue Dec 20, 2024 · 2 comments
Assignees
@marbre
Labels
bug 🐞 Something isn't working infrastructure Relating to build systems, CI, or testing

Comments

@Eliasj42
Copy link
Contributor

What happened?

CI - Linux x64 clang BYO LLVM is failing when building LLvm with the message

[261/2614] Building CXX object tools/mlir-opt/CMakeFiles/mlir-opt.dir/mlir-opt.cpp.o
FAILED: tools/mlir-opt/CMakeFiles/mlir-opt.dir/mlir-opt.cpp.o 
ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/__w/iree/iree/build-byo-llvm/mlir/tools/mlir-opt -I/__w/iree/iree/third_party/llvm-project/mlir/tools/mlir-opt -I/__w/iree/iree/build-byo-llvm/install/llvm/include -I/__w/iree/iree/third_party/llvm-project/mlir/include -I/__w/iree/iree/build-byo-llvm/mlir/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -Werror=mismatched-tags -O3 -DNDEBUG  -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -std=gnu++17 -MD -MT tools/mlir-opt/CMakeFiles/mlir-opt.dir/mlir-opt.cpp.o -MF tools/mlir-opt/CMakeFiles/mlir-opt.dir/mlir-opt.cpp.o.d -o tools/mlir-opt/CMakeFiles/mlir-opt.dir/mlir-opt.cpp.o -c /__w/iree/iree/third_party/llvm-project/mlir/tools/mlir-opt/mlir-opt.cpp
In file included from /__w/iree/iree/third_party/llvm-project/mlir/tools/mlir-opt/mlir-opt.cpp:14:
In file included from /__w/iree/iree/third_party/llvm-project/mlir/include/mlir/IR/AsmState.h:18:
In file included from /__w/iree/iree/third_party/llvm-project/mlir/include/mlir/IR/OperationSupport.h:18:
In file included from /__w/iree/iree/third_party/llvm-project/mlir/include/mlir/IR/BlockSupport.h:16:
In file included from /__w/iree/iree/third_party/llvm-project/mlir/include/mlir/IR/Value.h:17:
In file included from /__w/iree/iree/third_party/llvm-project/mlir/include/mlir/IR/UseDefLists.h:16:
/__w/iree/iree/third_party/llvm-project/mlir/include/mlir/IR/Location.h:145:10: fatal error: 'mlir/IR/BuiltinLocationAttributes.h.inc' file not found
#include "mlir/IR/BuiltinLocationAttributes.h.inc"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

and

[266/2614] Building CXX object tools/mlir-reduce/CMakeFiles/mlir-reduce.dir/mlir-reduce.cpp.o
FAILED: tools/mlir-reduce/CMakeFiles/mlir-reduce.dir/mlir-reduce.cpp.o 
ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/__w/iree/iree/build-byo-llvm/mlir/tools/mlir-reduce -I/__w/iree/iree/third_party/llvm-project/mlir/tools/mlir-reduce -I/__w/iree/iree/build-byo-llvm/install/llvm/include -I/__w/iree/iree/third_party/llvm-project/mlir/include -I/__w/iree/iree/build-byo-llvm/mlir/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -Werror=mismatched-tags -O3 -DNDEBUG  -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -std=gnu++17 -MD -MT tools/mlir-reduce/CMakeFiles/mlir-reduce.dir/mlir-reduce.cpp.o -MF tools/mlir-reduce/CMakeFiles/mlir-reduce.dir/mlir-reduce.cpp.o.d -o tools/mlir-reduce/CMakeFiles/mlir-reduce.dir/mlir-reduce.cpp.o -c /__w/iree/iree/third_party/llvm-project/mlir/tools/mlir-reduce/mlir-reduce.cpp
In file included from /__w/iree/iree/third_party/llvm-project/mlir/tools/mlir-reduce/mlir-reduce.cpp:16:
In file included from /__w/iree/iree/third_party/llvm-project/mlir/include/mlir/IR/Dialect.h:17:
In file included from /__w/iree/iree/third_party/llvm-project/mlir/include/mlir/IR/OperationSupport.h:18:
In file included from /__w/iree/iree/third_party/llvm-project/mlir/include/mlir/IR/BlockSupport.h:16:
In file included from /__w/iree/iree/third_party/llvm-project/mlir/include/mlir/IR/Value.h:17:
In file included from /__w/iree/iree/third_party/llvm-project/mlir/include/mlir/IR/UseDefLists.h:16:
/__w/iree/iree/third_party/llvm-project/mlir/include/mlir/IR/Location.h:145:10: fatal error: 'mlir/IR/BuiltinLocationAttributes.h.inc' file not found
#include "mlir/IR/BuiltinLocationAttributes.h.inc"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Steps to reproduce your issue

Failed workflow runs can be found here

What component(s) does this issue relate to?

No response

Version information

No response

Additional context

No response
@Eliasj42 Eliasj42 added bug 🐞 Something isn't working infrastructure Relating to build systems, CI, or testing labels Dec 20, 2024
@marbre marbre self-assigned this Jan 6, 2025
@marbre
Copy link
Member

marbre commented Jan 6, 2025

With llvm/llvm-project@10ef20f, support for MLIR_LINK_MLIR_DYLIB was introduced. With LLVM_LINK_LLVM_DYLIB set to ON at

iree/build_tools/llvm/llvm_config.cmake

Line 30 in cdf24b9

set(LLVM_BUILD_LLVM_DYLIB ON CACHE BOOL "")
, this setting is propagated to MLIR_LINK_MLIR_DYLIB. With MLIR_LINK_MLIR_DYLIB set to OFF, the build passes.

@marbre marbre mentioned this issue Jan 6, 2025
Merged
marbre added a commit that referenced this issue Jan 6, 2025
@marbre
Set MLIR_LINK_MLIR_DYLIB to not link shared libMLIR (#19613)
1445cef 
With llvm/llvm-project@10ef20f, support for `MLIR_LINK_MLIR_DYLIB` was
introduced. With `LLVM_LINK_LLVM_DYLIB` set to `ON` at
https://github.com/iree-org/iree/blob/cdf24b9be0354f06879ba08db85ff8a5dbe49b14/build_tools/llvm/llvm_config.cmake#L30,
this setting is propagated to `MLIR_LINK_MLIR_DYLIB`. This break the BYO
LLVM workflow, see #19549, hence, setting to `OFF`.
@ScottTodd
Copy link
Member

We have a workaround in place (disabling MLIR_LINK_MLIR_DYLIB). Calling this fixed for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marbre marbre

Labels
bug 🐞 Something isn't working infrastructure Relating to build systems, CI, or testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ScottTodd @marbre @Eliasj42