suppress exceptions when closing handlers during __del__
#912
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when `__del__` is called during process teardown, any amount of things may already be torn down and fail currently seeing this with `typing.cast` being None, preventing access of `self.log` (or any trait) from succeeding
minrk
force-pushed
the
suppress-close
branch
from
90aebd6 to
1d1e710
Compare
|
note that this suppresses the error that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when
__del__is called during process teardown, any amount of things may already be torn down and fail. Suppress those errors.currently seeing this with
typing.castbeing None, preventing access ofself.log(or any trait) from succeeding: jupyterhub/repo2docker#1379I'll work on a separate PR to remove most if not all use of
return cast(...)which doesn't do anything more thanreturn x # type:ignoreother than introduce possible errors like this and (negligible) performance cost.