Skip to content

Execute code in blocking mode by default #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: anyio
Choose a base branch
from
Open

Execute code in blocking mode by default #1233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ipykernel/ipkernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,7 @@ async def run(execution: Execution) -> None:
try:
async with create_task_group() as tg:
execution = Execution()
self.shell_is_blocking = False
self.shell_is_awaiting = True
tg.start_soon(run, execution)
execution.interrupt = await to_thread.run_sync(self.shell_interrupt.get)
Expand Down
2 changes: 2 additions & 0 deletions ipykernel/kernelbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,9 @@ async def execute_request(self, socket, ident, parent):
do_execute_args["cell_id"] = cell_id

# Call do_execute with the appropriate arguments
self.shell_is_blocking = True
reply_content = self.do_execute(**do_execute_args)
self.shell_is_blocking = False

if inspect.isawaitable(reply_content):
reply_content = await reply_content
Expand Down