Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the snap build configuration for the iptux part to use a snap-internal prefix, reorganize installed files into /usr, and add a missing runtime networking dependency to fix snap build/runtime issues. Flow diagram for iptux snap build and file reorganizationflowchart TD
A["Start snap build for iptux"] --> B["Run meson with --prefix=/snap/iptux/current/usr"]
B --> C["Install build artifacts under snap/iptux/current/usr"]
C --> D["Apply organize mapping: snap/iptux/current/usr -> usr"]
D --> E["Artifacts appear under /usr in final snap runtime"]
E --> F["Include stage-packages in snap"]
F --> F1["Add glib-networking (new runtime dependency)"]
F --> F2["Add libjsoncpp25"]
F --> F3["Add libsigc++-2.0-0v5"]
F --> F4["Add libayatana-appindicator3-1"]
F1 --> G["Snap runs with required networking support"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Hard-coding
--prefix=/snap/iptux/current/usrties the build output to a specific snap mount path; consider keeping a generic prefix (e.g./usr) and relying onorganizeor$SNAPCRAFT_PART_INSTALLto place files correctly at build time. - Since
organizeis now remappingsnap/iptux/current/usrtousr, double-check whether the meson--prefixis still needed at all, or if you can simplify by using the default prefix and only relying onorganizeto achieve the desired layout.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Hard-coding `--prefix=/snap/iptux/current/usr` ties the build output to a specific snap mount path; consider keeping a generic prefix (e.g. `/usr`) and relying on `organize` or `$SNAPCRAFT_PART_INSTALL` to place files correctly at build time.
- Since `organize` is now remapping `snap/iptux/current/usr` to `usr`, double-check whether the meson `--prefix` is still needed at all, or if you can simplify by using the default prefix and only relying on `organize` to achieve the desired layout.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
==========================================
+ Coverage 51.75% 51.76% +0.01%
==========================================
Files 64 64
Lines 8704 8704
==========================================
+ Hits 4505 4506 +1
+ Misses 4199 4198 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Snap packaging configuration to fix build and runtime issues for the iptux snap, primarily around install prefixes and required networking libraries.
Changes:
- Update the Meson install prefix for the
iptuxpart to/snap/iptux/current/usrand useorganizeto map that back tousrinside the snap payload. - Add
glib-networkingtostage-packagesto ensure the necessary GLib networking modules are present at runtime.
Summary by Sourcery
Adjust snap packaging configuration to resolve build and runtime issues in the snap.
Build: