Conversation
Closed
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The blink timer management logic is duplicated between AppIndicatorMac.mm and AppIndicator.cpp; consider extracting a small shared helper (or at least a common pattern/utility) so the behavior stays in sync and is easier to maintain.
- For managing blinkTimerId, consider using the GLib helper pattern (e.g., g_clear_handle_id-style logic) to ensure the ID is always cleared in a single place and to make repeated start/stop calls safer and less error-prone.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The blink timer management logic is duplicated between AppIndicatorMac.mm and AppIndicator.cpp; consider extracting a small shared helper (or at least a common pattern/utility) so the behavior stays in sync and is easier to maintain.
- For managing blinkTimerId, consider using the GLib helper pattern (e.g., g_clear_handle_id-style logic) to ensure the ID is always cleared in a single place and to make repeated start/stop calls safer and less error-prone.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #714 +/- ##
==========================================
- Coverage 52.11% 51.75% -0.36%
==========================================
Files 64 64
Lines 8641 8704 +63
==========================================
+ Hits 4503 4505 +2
- Misses 4138 4199 +61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
Summary by Sourcery
Add blinking behavior to the status icon when in blinking mode and unread messages are present, and stop blinking when the window becomes active.
New Features:
Enhancements: