-
Notifications
You must be signed in to change notification settings - Fork 41
Fix lint-rust action #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lint-rust action #151
Conversation
|
This seems to be caused by the I'm really no expert when it comes to rust's build systems. Any idea on how to resolve this? It seems similar to this issue I found: serde-rs/serde#1535 |
It also fails on CI, but I can't reproduce it locally :-/. What I would've tried would've been upgrading the crate to Rust edition 2021 (https://doc.rust-lang.org/edition-guide/editions/transitioning-an-existing-project-to-a-new-edition.html#transitioning-an-existing-project-to-a-new-edition). |
I think when I ran this locally I accidentally changed some |
|
Alright. I
The CI looks green on my fork, I'm pretty confident it'll be green here too @vmx |
🟢 🎉 |
Thanks a lot @matheus23 for working through all this and getting CI back to green! |
Work on #150
This fixes some issues introduced by compiling with rust 1.63 instead of 1.62.
I can't quite figure out the
no_std
problems though. It seems like there's some dependency that re-enables thestd
feature onserde
, but I don't know which and how to debug it. Here's the output I get from building for a no_std target: