move request query to http body (#45)

ipld · Jun 7, 2022 · 0af973b · 0af973b
1 parent 3c365e6
commit 0af973b
Show file tree

Hide file tree

Showing 8 changed files with 637 additions and 624 deletions.
diff --git a/blueprints/base/services.go b/blueprints/base/services.go
@@ -27,6 +27,7 @@ var (
 	IOReadCloser       = &cg.GoRef{PkgPath: "io", Name: "ReadCloser"}
 	IOEOF              = &cg.GoRef{PkgPath: "io", Name: "EOF"}
 	IOErrUnexpectedEOF = &cg.GoRef{PkgPath: "io", Name: "ErrUnexpectedEOF"}
+	IOUtilReadAll      = &cg.GoRef{PkgPath: "io/ioutil", Name: "ReadAll"}
 )
 
 const EdelweissServicesPkg = services.PkgPath

diff --git a/blueprints/services/dagjson-over-http/client.go b/blueprints/services/dagjson-over-http/client.go
@@ -230,9 +230,6 @@ func (c *{{.Type}}) {{.AsyncMethodDecl}} {
 
 	// encode request in URL
 	u := *c.endpoint
-	q := {{.URLValues}}{}
-	q.Set("q", string(buf))
-	u.RawQuery = q.Encode()
 	httpReq, err := {{.HTTPNewRequestWithContext}}(ctx, "POST", u.String(), {{.BytesNewReader}}(buf))
 	if err != nil {
 		return nil, err

diff --git a/blueprints/services/dagjson-over-http/server.go b/blueprints/services/dagjson-over-http/server.go
@@ -121,6 +121,7 @@ func (x GoServerImpl) GoDef() cg.Blueprint {
 		"HTTPResponseWriter": base.HTTPResponseWriter,
 		"IPLDDecode":         base.IPLDDecode,
 		"DAGJSONDecode":      base.DAGJSONDecode,
+		"IOUtilReadAll":      base.IOUtilReadAll,
 		//
 		"Interface":    x.Ref.Append("_Server"),
 		"AsyncHandler": x.Ref.Append("_AsyncHandler"),
@@ -150,8 +151,13 @@ type {{.Interface}} interface {
 func {{.AsyncHandler}}(s {{.Interface}}) {{.HTTPHandlerFunc}} {
 	return func(writer {{.HTTPResponseWriter}}, request *{{.HTTPRequest}}) {
 		// parse request
-		msg := request.URL.Query().Get("q")
-		n, err := {{.IPLDDecode}}([]byte(msg), {{.DAGJSONDecode}})
+		msg, err := {{.IOUtilReadAll}}(request.Body)
+		if err != nil {
+			{{.LoggerVar}}.Errorf("reading request body (%v)", err)
+			writer.WriteHeader(400)
+			return
+		}
+		n, err := {{.IPLDDecode}}(msg, {{.DAGJSONDecode}})
 		if err != nil {
 			{{.LoggerVar}}.Errorf("received request not decodeable (%v)", err)
 			writer.WriteHeader(400)