Skip to content

UX improvements #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 6, 2020
Merged

UX improvements #85

merged 3 commits into from
Jan 6, 2020

Conversation

lidel
Copy link
Member

@lidel lidel commented Dec 30, 2019 •
edited
Loading

Various UX tweaks on top of #83 by @lazyweirdo:

  • added link to github repo in the right corner (https://github.com/tholman/github-corners)
  • switched to colors and fonts from https://github.com/ipfs-shipyard/ipfs-css
    • I did not rewrite entire thing to use tachyons to keep this PR small
  • same font size in all columns (fixes this bug)
  • improved links about CORS and Origin tests
  • removed .ipfs. from displayed hostnames of subdomain gateways
  • long hostnames get truncated on narrow screens without breaking layout (demo)
  • README: added note how to test locally: 
    $ npx http-server . -a 127.0.0.1 -p 3000 -c-1

TODO

  • get 👍 from someone with MS Windows and Max OS (@jamiew? @lazyweirdo?)
    • just open this and let me know if anything looks off

Preview

LIVE: http://bafybeih5ijnzskerps5zc6uhvmtsl7hf2bkjcfh3t26cpm7cj7u2j3pkq4.ipfs.dweb.link/

Screenshots

Screen Shot 2019-12-30 at 19 48 45

Narrow screen (like iPhone XS):

Screen Shot 2019-12-30 at 19 49 19

lidel added 3 commits December 30, 2019 19:34
@lidel
feat: use fonts from ipfs-css
c393c99 
- same font size in all columns
- improved links to CORS and Origin
- remove .ipfs. from subdomain gateways

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
@lidel
docs: how to test locally
1b1cf5b 
License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
@lidel
chore: update lastpubver
0c45e00 
License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
@lazyweirdo
Copy link
Contributor

lazyweirdo commented Dec 30, 2019 •
edited
Loading

nice 😄

get +1 from someone with MS Windows and Max OS (@jamiew? @lazyweirdo?)
just open this and let me know if anything looks off

Linux chromium, firefox looks fine
Mac safari looks also great
Windows, what is it ?

@lidel lidel merged commit 3cf5f40 into master Jan 6, 2020
@lidel lidel deleted the feat/ipfs-css branch January 6, 2020 13:03
@jamiew
Copy link
Contributor

jamiew commented Jan 6, 2020

Late to the party but looks great to me! Will update the README screenshot shortly too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lidel @lazyweirdo @jamiew