Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update boxo with routing streaming #9868

Merged
merged 1 commit into from
May 10, 2023
Merged

feat: update boxo with routing streaming #9868

merged 1 commit into from
May 10, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented May 10, 2023

Updates Kubo with ipfs/boxo#18.

This is blocking other PRs, such as ipfs/boxo#292.

@hacdias hacdias requested a review from a team as a code owner May 10, 2023 07:54
@hacdias hacdias mentioned this pull request May 10, 2023
1 task
@hacdias hacdias self-assigned this May 10, 2023
@hacdias hacdias enabled auto-merge (squash) May 10, 2023 08:10
@hacdias hacdias merged commit 0e7331c into master May 10, 2023
@hacdias hacdias deleted the update-boxo branch May 10, 2023 08:15
@@ -17,6 +17,7 @@ func TestHTTPDelegatedRouting(t *testing.T) {

fakeServer := func(resp string) *httptest.Server {
return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
Copy link
Member

@lidel lidel May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hacdias this means we are not testing streaming 🙃
Filled #9873

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants