Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pop-up menu and share page tweaks #907

Merged
merged 49 commits into from
Jul 8, 2020
Merged
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
db28789
Pop-up header: Rearrange items for height/clarity, remove stars
jessicaschilling Jul 1, 2020
765df30
Toolbar: first steps
jessicaschilling Jul 2, 2020
931cd00
Two buttons: share files, go to my node
jessicaschilling Jul 2, 2020
ab39ca1
Peers to top of status list
jessicaschilling Jul 2, 2020
9b115cf
Remove tools header; "Active Tab" -> "Current Tab"
jessicaschilling Jul 2, 2020
b98265f
Global gateway toggle to appear next to gateway status
jessicaschilling Jul 2, 2020
4de72b8
Rearrange gateway toggle in prep for making an a/b switch
jessicaschilling Jul 2, 2020
53244da
Revert "Rearrange gateway toggle in prep for making an a/b switch"
jessicaschilling Jul 2, 2020
eb764d1
Revert "Global gateway toggle to appear next to gateway status"
jessicaschilling Jul 2, 2020
da2e71d
Revert "Remove tools header; "Active Tab" -> "Current Tab""
jessicaschilling Jul 2, 2020
6f0854f
Revert "Peers to top of status list"
jessicaschilling Jul 2, 2020
95c96da
Revert "Two buttons: share files, go to my node"
jessicaschilling Jul 2, 2020
95e9624
Revert "Toolbar: first steps"
jessicaschilling Jul 2, 2020
0da74d9
Peers first in status list
jessicaschilling Jul 2, 2020
4e84639
Add hover titles for all items in header area
jessicaschilling Jul 2, 2020
b1ad4eb
Restyle menu titles and change to "Current Tab"
jessicaschilling Jul 2, 2020
3975ad8
Reword Tools menu items
jessicaschilling Jul 2, 2020
3f9ff23
Remove global gateway toggle per convo with @olizilla
jessicaschilling Jul 2, 2020
ff1c7e9
Remove panel_toolsSectionHeader
jessicaschilling Jul 2, 2020
fe8cf03
Add border-top to nav-header, remove extraneous nav-header and browse…
jessicaschilling Jul 3, 2020
b8169c3
Remove extraneous browser and nav-header refs
jessicaschilling Jul 3, 2020
42d1d32
Smaller text, border between tools and contextual items
jessicaschilling Jul 3, 2020
3c347a1
Spacing cleanup in menu items
jessicaschilling Jul 3, 2020
75bb812
Uppercase/lowercase menu and notification items to match system/brows…
jessicaschilling Jul 3, 2020
a39e971
Menu item: "Share Files via IPFS..." -> "Quick Import/Share"
jessicaschilling Jul 3, 2020
ef0a59a
Sharing page: Add discrete title and clarify "share"
jessicaschilling Jul 3, 2020
57be246
Update nav-item.js
jessicaschilling Jul 3, 2020
9b3587e
Narrow subhead affordance so it doesn't run into toggles
jessicaschilling Jul 3, 2020
73e3b8d
Subhead helperText now dynamic, but no real values yet
jessicaschilling Jul 3, 2020
ed07dbf
helperText titles updated to equivalents in copier.js, but not live-l…
jessicaschilling Jul 3, 2020
99729ef
Gradient from ipfs-css, resolves https://github.com/ipfs-shipyard/ipf…
jessicaschilling Jul 3, 2020
0c1128e
Update add-on/_locales/en/messages.json
jessicaschilling Jul 3, 2020
f65c512
Update add-on/_locales/en/messages.json
jessicaschilling Jul 3, 2020
efe4298
Add hover text to IPFS version in header
jessicaschilling Jul 3, 2020
a9c0f8e
Merge branch 'feat/popup-header-tweaks' of https://github.com/ipfs-sh…
jessicaschilling Jul 3, 2020
568d24a
Remove margin repetition
jessicaschilling Jul 3, 2020
34c9b0d
refactor: wire up hints for copy actions
lidel Jul 8, 2020
626b3eb
fix: async CID resolution for main menu
lidel Jul 8, 2020
395b5bb
Tweak not-ready message
jessicaschilling Jul 8, 2020
4baea0d
nit: standardize page titles for welcome, prefs, share
jessicaschilling Jul 8, 2020
64e58c7
Tweak prefs page language related to gateways
jessicaschilling Jul 8, 2020
9648df4
Clarify "Pin IPFS Resource" tool tip
jessicaschilling Jul 8, 2020
399d658
Flipped page titles for consistency with docs.ipfs.io
jessicaschilling Jul 8, 2020
b264175
Add tooltips for all pop-up menu items
jessicaschilling Jul 8, 2020
e03ecfc
Merge branch 'master' into feat/popup-header-tweaks
lidel Jul 8, 2020
51a340f
Update add-on/_locales/en/messages.json
jessicaschilling Jul 8, 2020
0ded347
address bar text
jessicaschilling Jul 8, 2020
5997e22
Merge branch 'feat/popup-header-tweaks' of https://github.com/ipfs-sh…
jessicaschilling Jul 8, 2020
125ee93
Simply "reset everything" prefs text
jessicaschilling Jul 8, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove panel_toolsSectionHeader
jessicaschilling committed Jul 2, 2020
commit ff1c7e9b963bcff7f25a89abd5bd13ba9520d937
4 changes: 0 additions & 4 deletions add-on/_locales/en/messages.json
Original file line number Diff line number Diff line change
@@ -63,10 +63,6 @@
"message": "Click to toggle all gateway redirects",
"description": "A menu item in Browser Action pop-up (panel_redirectToggleTooltip)"
},
"panel_toolsSectionHeader": {
"message": "Tools",
"description": "A menu item in Browser Action pop-up (panel_toolsSectionHeader)"
},
"panel_openPreferences": {
"message": "Open IPFS Companion preferences",
"description": "A menu item in Browser Action pop-up (panel_openPreferences)"
2 changes: 1 addition & 1 deletion add-on/src/popup/browser-action/page.js
Original file line number Diff line number Diff line change
@@ -30,8 +30,8 @@ module.exports = function browserActionPage (state, emit) {
return html`
<div class="sans-serif" style="text-rendering: optimizeLegibility;">
${header(headerProps)}
${activeTabActions(activeTabActionsProps)}
${tools(opsProps)}
${activeTabActions(activeTabActionsProps)}
</div>
`
}
3 changes: 0 additions & 3 deletions add-on/src/popup/browser-action/tools.js
Original file line number Diff line number Diff line change
@@ -18,8 +18,6 @@ module.exports = function tools ({
const activeWebUI = active && isIpfsOnline && ipfsNodeType !== 'embedded'

return html`
<div>
${navHeader('panel_toolsSectionHeader')}
<div class="fade-in pt1">
${navItem({
text: browser.i18n.getMessage('panel_quickImport'),
@@ -32,6 +30,5 @@ module.exports = function tools ({
onClick: onOpenWebUi
})}
</div>
</div>
`
}