test: basic routing interface test #103
Conversation
| // Put routing value. | ||
| err = apis[0].Routing().Put(ctx, "/ipns/"+ipnsEntry.Name(), data) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } |
There was a problem hiding this comment.
Would be nice if we would try to fetch the thing we stored, this would catch silent failure, with the current setup that would not work since you don't know if this was stored by the original ipns publish or the second put.
There was a problem hiding this comment.
@Jorropo i can do that too. I didn't do it initially for illustration purposes since I didn't want to be adding random things.
There was a problem hiding this comment.
@Jorropo actually, I think there must be some kind of internal verification afterwards. If you do ipfs routing put and then get, you won't get the same result. For example, if you put random data on your self key, you'll just get the latest ipns key. So I think there's some DHT verification somewhere to avoid invalid data to getting added.
There was a problem hiding this comment.
|
that enough to make progress on ipfs/go-ipfs-http-client#168, ty 🎉 |
|
Suggested version: Changes in diff --git a/go.mod b/go.mod
index af97472..2688cf3 100644
--- a/go.mod
+++ b/go.mod
@@ -66,4 +66,4 @@ require (
lukechampine.com/blake3 v1.1.7 // indirect
)
-go 1.18
+go 1.19
Cutting a Release (and modifying non-markdown files)This PR is modifying both Automatically created GitHub ReleaseA draft GitHub Release has been created. |
Adds missing tests from #91. The tests depend on other APIs. Feel free to suggest improvements to depend less on others. PR in Kubo with this commit: ipfs/kubo#9628
Also, while doing this, I realised that the interface we added for the routing API might not be the most intuitive: see #104.