-
Couldn't load subscription status.
- Fork 13
feat: support provider query parameter #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vasco-santos
wants to merge
4
commits into
main
Choose a base branch
from
feat/support-provider-query-parameter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a4991e to
997cf3a
Compare
vasco-santos
commented
May 23, 2025
| blockBrokerRetrieveCalledWithProviders.resolve(options.providers) | ||
|
|
||
| // attempt to read from the provider | ||
| // eslint-disable-next-line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint complains there is too many nested callbacks 😬
b7df559 to
b7b8dc4
Compare
b7b8dc4 to
c30629a
Compare
lidel
reviewed
May 23, 2025
…eter as experimental
183cf99 to
03a573d
Compare
3 tasks
|
Triage note:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for provider query parameter
Description
This PR propagates provider from query parameters as described in https://github.com/vasco-santos/provider-hinted-uri/blob/main/EXPLORATION.md#-uri-design to be used as Hints by Helia's blockBrokers.
Regarding changes, it simply changes
parseUrlStringutil function to verify if valid multiaddrs are in the query parameters and also returns them. They are then simply propagated to theoptionsparameter that makes its way to the plugins pipeline, where a broker session is created and is used.These feature is currently behind a feature flag while it is in experimental stage (
allowProviderParameter)Notes & open questions
Currently does not embed proto in the multiaddrs (for instance
/retrieval/bitswap/retrieval/http). We will as follow up discuss how to support something along these lines.@achingbrain while this is more experimental, opted to not add example in Readme. Should I add though?
Change checklist