This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Allow CID functions to work with non-default multibase. #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
FromCid
function to take a function which translates a Cid to s string.Yes, (1) is an API change but I greatly prefer it to creating another another tediously named function. This function is not used in many places within
go-ipfs
. In almost all cases we should be passing in a transformer function anyway, and when we don't have onenil
can be used instead. The general idea is we should eventually get the transformer function from the current context which is nearly always available whenFromCid
is used. A function is used instead of just a multibase encoding for added flexibility, for example we may want to upgrade CidV0 to CidV1.CC @Stebalien