Skip to content

Commit

Permalink
fix: relax dag-cbor error check (#205)
Browse files Browse the repository at this point in the history
  • Loading branch information
lidel authored Apr 18, 2024
1 parent 27038a7 commit 41f88f8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
- Relaxed the DAG-CBOR error check: we no longer check the body of the response, only the status code. [PR](https://github.com/ipfs/gateway-conformance/pull/205)

## [0.5.1] - 2024-04-11
- Removed byte range text for DAG-CBOR objects converted to `text/html`. [PR](https://github.com/ipfs/gateway-conformance/pull/202)
Expand Down
6 changes: 2 additions & 4 deletions tests/path_gateway_dag_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -367,8 +367,7 @@ func TestPathing(t *testing.T) {
Path("/ipfs/{{cid}}/foo", dagJSONTraversalCID).
Query("format", "dag-json"),
Response: Expect().
Status(501).
Body(Contains("reading IPLD Kinds other than Links (CBOR Tag 42) is not implemented")),
Status(501), // reading IPLD Kinds other than Links (CBOR Tag 42) is not implemented
},
{
Name: "GET DAG-JSON traverses multiple links",
Expand Down Expand Up @@ -396,8 +395,7 @@ func TestPathing(t *testing.T) {
Path("/ipfs/{{cid}}/foo", dagCBORTraversalCID).
Query("format", "dag-cbor"),
Response: Expect().
Status(501).
Body(Contains("reading IPLD Kinds other than Links (CBOR Tag 42) is not implemented")),
Status(501), // reading IPLD Kinds other than Links (CBOR Tag 42) is not implemented
},
{
Name: "GET DAG-CBOR traverses multiple links",
Expand Down

0 comments on commit 41f88f8

Please sign in to comment.