Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Targeted Grant: Active local discovery in Brave #14

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Targeted Grant: Active local discovery in Brave #14

merged 2 commits into from
Feb 5, 2020

Conversation

lidel
Copy link
Member

@lidel lidel commented Jan 30, 2020 •
edited
Loading

This PR adds RFP 001: Active local discovery in Brave:

This project’s goal is to get active local peer discovery working in IPFS-Companion on the Brave browser when embedded JS-IPFS node is used.

[..] Secondary goal is to test and refine the RFP process.

cc @autonome @parkan @RangerMauve ipfs/in-web-browsers#45

@lidel
Create rfp-001--active-local-discovery-in-brave.md
ca2c37c 
This adds RFP 001: Active local discovery in Brave
@lidel lidel requested review from autonome, parkan and momack2 January 30, 2020 18:43
momack2
momack2 approved these changes Feb 3, 2020
View reviewed changes
Copy link
Collaborator

@momack2 momack2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @lidel - feel free to post!

@parkan parkan added the type:targeted-grant A grant made directly to a specific recipient label Feb 4, 2020
@lidel
Convert Brave RFP to "Targeted Grant"
ddd9db2 
This applies suggestion made by @parkan to align Brave grant
with other "open grants" that were pre-approved before devgrants went
live.

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
@lidel lidel changed the title Add RFP 001: Active local discovery in Brave Targeted Grant: Active local discovery in Brave Feb 5, 2020
@lidel
Copy link
Member Author

lidel commented Feb 5, 2020 •
edited
Loading

@parkan I moved this from RFP to Open Grants to match other existing "targeted grants" – let me know if anything else needs to be done.

@RangerMauve the grant now explicitly states you as the owner, so you don't need to apply for it.

parkan
parkan approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@parkan parkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@parkan
Copy link
Contributor

parkan commented Feb 5, 2020

merging this, will move it around as needed while we firm up Targeted Grant terminology etc

@parkan parkan merged commit 450237c into master Feb 5, 2020
@RangerMauve
Copy link
Contributor

Awesome! This all looks good to me. :)

@lidel lidel deleted the rfp-001--active-local-discovery-in-brave branch February 7, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkan parkan parkan approved these changes

@momack2 momack2 momack2 approved these changes

@autonome autonome Awaiting requested review from autonome

Assignees
No one assigned
Labels
type:targeted-grant A grant made directly to a specific recipient
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lidel @parkan @RangerMauve @momack2