Add section on "Error Codes" to CONTRIBUTING_JS.md #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add section on error codes Ref. ipfs/js-ipfs#2547 (comment)
terichadbourne
suggested changes
Nov 4, 2019
Co-Authored-By: Teri Chadbourne <[email protected]>
alanshaw
reviewed
Nov 4, 2019
hugomrdias
approved these changes
Nov 5, 2019
vasco-santos
approved these changes
Nov 5, 2019
License: MIT Signed-off-by: Marcin Rataj <[email protected]>
lidel
requested review from
hugomrdias,
jacobheun,
alanshaw and
terichadbourne
alanshaw
approved these changes
Nov 8, 2019
There was a problem hiding this comment.
Cool, I like this, might be worth saying something about the convention for codes (uppercase and starting with "ERR_") to avoid any more bikeshedding in the future :D
I also want @hugomrdias and @achingbrain's approval on this before merging so we're all aligned going forward. 🙏
jacobheun
approved these changes
Nov 8, 2019
hugomrdias
approved these changes
Nov 8, 2019
achingbrain
approved these changes
Nov 8, 2019
Co-Authored-By: Teri Chadbourne <[email protected]>
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds section on defining and reusing Error Codes, as requested in ipfs/js-ipfs#2547 (comment)
Used
Errorsfrominterface-datastoreas an example.