Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename #148

Closed
Closed

Conversation

AliabbasMerchant
Copy link
Member

This is a continuation of #144
@Alexander255 I think there may have been a problem in merging #144
The main 'Code' section of the repo is not showing any commits.
Also, I have made the 2 test_http.py corrections.

@ntninja
Copy link
Contributor

ntninja commented Dec 15, 2018

No, the merging went fine but I immediately move the commits off the master branch to https://github.com/ipfs/py-ipfs-api/tree/py-ipfs-http-client , which is where I'll land a few backward-incompatible changes (mostly #146 and #133) before going all-in. There aren't many occasions where you get that kind of opportunity after all.

Are interested in helping me out on these by any chance? Issue #133 should be fairly easy to solve, but doesn't have any code yet.

@ntninja
Copy link
Contributor

ntninja commented Jan 27, 2019

Closing this, since already merged.

@ntninja ntninja closed this Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants