This repository was archived by the owner on Mar 10, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 109
[WIP] fix: ipns tests using go daemon #360
Open
vasco-santos
wants to merge
1
commit into
master
Choose a base branch
from
fix/ipns-tests-using-go-daemon
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,7 +41,7 @@ module.exports = (createCommon, options) => { | |
after((done) => common.teardown(done)) | ||
|
||
it('should resolve a record with the default params after a publish', function (done) { | ||
this.timeout(50 * 1000) | ||
this.timeout(120 * 1000) | ||
|
||
const value = fixture.cid | ||
|
||
|
@@ -52,22 +52,20 @@ module.exports = (createCommon, options) => { | |
ipfs.name.resolve(nodeId, (err, res) => { | ||
expect(err).to.not.exist() | ||
expect(res).to.exist() | ||
expect(res.path).to.equal(`/ipfs/${value}`) | ||
expect(res.path || res).to.equal(`/ipfs/${value}`) // TODO | ||
|
||
done() | ||
}) | ||
}) | ||
}) | ||
|
||
it('should not get the entry if its validity time expired', function (done) { | ||
this.timeout(50 * 1000) | ||
this.timeout(140 * 1000) | ||
|
||
const value = fixture.cid | ||
const publishOptions = { | ||
resolve: true, | ||
lifetime: '1ms', | ||
ttl: '10s', | ||
key: 'self' | ||
resolve: false, | ||
lifetime: '10ms' | ||
} | ||
|
||
ipfs.name.publish(value, publishOptions, (err, res) => { | ||
|
@@ -83,12 +81,12 @@ module.exports = (createCommon, options) => { | |
|
||
done() | ||
}) | ||
}, 1) | ||
}, 10) | ||
}) | ||
}) | ||
|
||
it('should recursively resolve to an IPFS hash', function (done) { | ||
this.timeout(100 * 1000) | ||
this.timeout(150 * 1000) | ||
|
||
const value = fixture.cid | ||
const publishOptions = { | ||
|
@@ -125,7 +123,7 @@ module.exports = (createCommon, options) => { | |
ipfs.name.resolve(keyId, resolveOptions, (err, res) => { | ||
expect(err).to.not.exist() | ||
expect(res).to.exist() | ||
expect(res.path).to.equal(`/ipfs/${value}`) | ||
expect(res.path || res).to.equal(`/ipfs/${value}`) // TODO | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems wrong, tests should test one thing and here is a conditional ( There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes! That will be changed 🙂 But for explaining the purpose, I am experiencing different responses when the daemon is online and offline. One has the path property, while the other does not have. I will keep this in |
||
|
||
done() | ||
}) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than having this is a timeout, we should have something similar to this: https://github.com/ipfs/interface-ipfs-core/blob/master/js/src/pubsub/utils.js#L5-L31
Where we execute the expectations once every 100 milliseconds until either it passes or we've tried 10 times. This will make the test less likely to fail on lower performance machines.