Skip to content

Conversation

@AdamGreenAwardMatcher
Copy link

Simple fix of type signatures for non nested querying using firedantic. Only a type hint change, so no runtime impact on library. Just makes the type signatures align with the functionality.

  • Fixed type signature for filter_ parameter in find() and find_one() methods
  • Now correctly supports int, float, and bool types in addition to str
  • Updated both async and sync versions via unasync

Previously a query like this:

    entities = await FiredanticEntity.find(
        {"business_id": business_id, "is_deleted": False}
    )

Would cause a typing error, with the changes it now does not.

AdamGreenAwardMatcher and others added 3 commits August 2, 2025 17:51
The filter_ parameter in find() and find_one() methods now correctly
supports int, float, and bool types in addition to str, matching
actual Firestore usage patterns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant