fix: default props to new way to not throw warning #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipe-silveira-dev
approved these changes
Jun 27, 2024
|
Nice work! Can't wait for this to be released :) |
christhoval06
approved these changes
Aug 29, 2024
|
Hi, may I know when it would be released? |
thomascwo
reviewed
Jan 10, 2025
|
|
||
| const AutoHeightWebView = React.memo( | ||
| forwardRef((props, ref) => { | ||
| forwardRef((props = defaultProps, ref) => { |
There was a problem hiding this comment.
It seems having any one of the prop passed in will override all the defaultProps.
|
Will this be released? It has been a half year... is the package still be maintained? |
|
@aliceni81 I don't think so. I'm now using @builder.io/react-native-render-html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a modern way to pass defaultProps to component props to avoid throw warning.
Warning: ForwardRef: Support for defaultProps will be removed from memo components in a future major release. Use JavaScript default parameters instead.