Conversation
…compatibility gnark-crypto v0.18.1 (pulled in by iotex-core v2.4) renamed the build tag for disabling assembly from `generic` to `purego`. The new assembly packages (field/asm/element_4w, element_6w) have no build constraints and use R15/VALIGND patterns incompatible with -dynlink mode required by -buildmode=plugin. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
iotex-core v2.4.0-rc2 transitively bumped gnark-crypto to v0.18.1, which introduced fptower assembly files (e2_amd64.s) without `!generic`/`!purego` build guards. Their R15 register usage and SB-relative VALIGND globals are incompatible with the `-dynlink` mode that `-buildmode=plugin` enables. Pinning to v0.12.1 (the version analyser used pre-upgrade, known to build plugins cleanly with `-tags generic`). iotex-core has no direct gnark-crypto usage; only transitive via go-ethereum's EVM precompiles, whose API surface is stable across these versions. Reverts the Makefile tag back to `generic` to match v0.12.1's guard style. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
YAP fork activates EIP-7702 SetCode tx (type 4), which the action_type plugin previously rejected with "unknown tx type 4". Insert a SetCodeTxType case into the existing fallthrough chain so the auth list is recorded and the dynamic-fee/access-list fields still flow through. Add an AuthList jsonb column on the ActionType model. Blob txs also fall through this case but the `len(auths) > 0` guard keeps AuthList unset for them (BlobTx.SetCodeAuthorizations returns nil). Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project's dependencies in
go.modto newer versions, introduces new and updated indirect dependencies, and adjusts some module replacements to point to newer or alternative forks. It also modifies the instantiation of a gRPC BlockDAO inserver/server.goto include an additional parameter.Dependency upgrades and additions:
1.24.6and upgraded many direct dependencies, includinggithub.com/urfave/cli/v2,github.com/stretchr/testify,github.com/prometheus/client_golang, and others. Addedgithub.com/fergusstrange/embedded-postgresas a direct dependency.anacrolix,bits-and-blooms,cockroachdb,consensys,crate-crypto,decred,ethereum,goccy,golang-jwt,holiman,ipfs,klauspost,libp2p,multiformats,pion,prometheus,quic-go,xrash,uber,golang.org/x/*, and others. Some indirect dependencies were removed or replaced with updated alternatives. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Module replacement and fork updates:
replacedirectives to point to new versions or different forks of key modules, such asgithub.com/ethereum/go-ethereum,github.com/erigontech/erigon,github.com/erigontech/erigon-lib, andgithub.com/gballet/go-verkle. Added a replacement forgithub.com/ethereum/go-ethereum/crypto/secp256k1.Code change for BlockDAO initialization:
blockdao.NewGrpcBlockDAOinserver/server.goto add a new integer parameter (100), likely configuring a new option or buffer size for the DAO.