fix: SSH provisioning for existing node pools when AppendRKEProvisionUserData is false #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UserData is false - Always add SSH user configuration to cloud-init when RKE provisioning is involved - Ensures proper SSH access for both new and existing node pools - Fixes issue where existing node pools failed deployment when AppendRKEProvisionUserData flag was false - Updated tests to reflect new expected behavior - Updated changelog for version 7.0.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes SSH provisioning issue for existing node pools when
AppendRKEProvisionUserDatais false.Problem
AppendRKEProvisionUserDatawas false (default), SSH user configuration wasn't added to cloud-initSolution
Changes
GetFinalUserData()to check forRKEProvisionUserDatapresenceTesting
TestGetFinalUserData*testsRelated Issue
Closes #128
Type of Change
Checklist
feat:/fix:/doc:/test:/refactor:)