-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: proxy component #6084
Draft
johnjenkins
wants to merge
20
commits into
ionic-team:main
Choose a base branch
from
johnjenkins:refactor-proxy-component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor: proxy component #6084
johnjenkins
wants to merge
20
commits into
ionic-team:main
from
johnjenkins:refactor-proxy-component
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note - this is relying on #6076 to be merged first
What is the current behavior?
Following on from #6076 I delved into runtime decorators in combination with Stencil decorated members and found them to be quite limited.
One of the most useful things of property decorators is their ability to augment a class' prototype.
For example, If you want validation on an incoming value - e.g. an incoming number should be clamped between a floor and ceiling - you could use a decorator to add
get()
/set()
accessors, checking and amending the incoming value.Unfortunately, for
@State
and@Prop
members, Stencil set's up it's ownget()
andset()
and overrides any set on the prototype via decorators.This gets in the way of expected / native behaviour.
GitHub Issue Number: N/A
What is the new behavior?
proxy-component.ts
has been refactored:Documentation
Does this introduce a breaking change?
Testing
I plan on adding some more run-time decorator tests
Other information