Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(textarea): update helper text and counter color #30148

Open
wants to merge 14 commits into
base: feature-8.5
Choose a base branch
from
Open

fix(textarea): update helper text and counter color #30148

wants to merge 14 commits into from
+299 −177

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jan 22, 2025 •
edited
Loading

Issue number: N/A

What is the current behavior?

Helper text is lighter than it should be.

What is the new behavior?

  • Updates helper and counter text to match MD design
  • Updates e2e test to include more coverage

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

Note that the fill toggle will only work in md mode

@vercel Vercel
Copy link

vercel bot commented Jan 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 8:46pm

@github-actions github-actions bot added the package: core @ionic/core package label Jan 22, 2025
@brandyscarney brandyscarney changed the title feat(textarea): add css vars for helper and error text fix(textarea): update helper text color Jan 22, 2025
@brandyscarney brandyscarney changed the title fix(textarea): update helper text color fix(textarea): update helper text and counter color Jan 22, 2025
@brandyscarney brandyscarney marked this pull request as ready for review January 22, 2025 20:25
@brandyscarney brandyscarney requested a review from a team as a code owner January 22, 2025 20:25
@brandyscarney brandyscarney requested review from OS-giulianasilva and thetaPC and removed request for OS-giulianasilva January 22, 2025 20:25
thetaPC
thetaPC approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thetaPC thetaPC requested a review from joselrio January 24, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC thetaPC approved these changes

@joselrio joselrio Awaiting requested review from joselrio

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandyscarney @thetaPC