-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: System Bars Plugin #8180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: System Bars Plugin #8180
Conversation
This looks great, what more is needed before merge? |
I am noticing that currently, without this plugin, the safe area and the status bar are working great on iOS -- it even changes the status bar text depending on light or dark mode when I toggle dark on the root: I am noticing this PR includes some styling on the status bar. Is there any way to have Android act like the iOS and have it "just work"? I also want to make sure this won't break what we have working fine on iOS. |
I am not sure if you have a correct understanding of this "inject css variables" thing. It doesn't inject |
I'd like to add that as of November 1st (actually earlier, but Google granted an extension to developers that depend on older SDKs) no one will be able to publish a release to the play store if they're not supporting edge-to-edge. So I think this should be given the utmost priority by the Capacitor team |
I just discovered all of this was only a problem with an Android Medium emulator. I just tried the Pixel 9 emulator and safe area is working great without any plugins. |
Hello everyone! Stay tuned, I'm on the verge of getting this past the finish line, The plan is to make some final changes and wrap this up this week. |
By "just work", you're expecting just the default status bar, without the fullscreen / transparent status bar style, correct? |
I'm curious which approach you've chosen to go with. I'm still advocating for going the native route. To demonstrate how that would work I made a simple demo proof of concept. Mind you that I've created this in like 5 minutes, so it's still not perfect, but you will get the main idea. Demo: https://github.com/tafelnl/capacitor-demo I also commented some todos which I haven't done because it's a proof of concept. |
No description provided.