Inject Capacitor JS for error fallbacks. #7781
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpojer
commented
Nov 28, 2024
| String allowedOrigin = Uri.parse(appUrl).buildUpon().path(null).fragment(null).clearQuery().build().toString(); | ||
| Set<String> allowedOrigins = new HashSet<>(Arrays.asList( | ||
| Uri.parse(appUrl).buildUpon().path(null).fragment(null).clearQuery().build().toString(), | ||
| "https://localhost" |
There was a problem hiding this comment.
Is there ever a situation where we'd also want to add http://localhost?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a local
server.errorPathin conjunction with a remoteserver.url, and the device is offline, Capacitor does not inject its JS becauseallowedOriginwill be set to the remoteserver.urlhostname, while the error is loaded from the local server. This means that plugins and other Capacitor/Cordova functionality are unavailable in this situation.This PR adds
https://localhostas anallowedOrigin, ensuring that all the Capacitor JS is being included in the error case.There is a related PR for the case when the document start script feature is not supported: #6247