Skip to content

feat(app): Add 'getAppLanguageCode' and 'getAppLanguageTag' #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(app): Add 'getAppLanguageCode' and 'getAppLanguageTag' #1694

wants to merge 7 commits into from

Conversation

philet
Copy link

@philet philet commented Jul 19, 2023

Solves #1693

@philet philet force-pushed the add-app-language-getters branch from 604ec65 to c1cb2d4 Compare July 19, 2023 12:38
@dallastjames dallastjames added the type: feature request A new feature, enhancement, or improvement label Jul 28, 2023
@dallastjames dallastjames added the pr review requested Adds PR to internal issue tracker for team review label Aug 7, 2023
IT-MikeS
IT-MikeS suggested changes Aug 15, 2023
View reviewed changes
@jcesarmobile jcesarmobile mentioned this pull request Aug 23, 2023
Open
@jcesarmobile
Copy link
Member

I've addressed the changes requested by Mike and added two buttons on the test app for testing
ionic-team/capacitor-testapp#628

But I've noticed that getAppLanguageTag() is also returning a 2 language code on iOS instead of the documented "IETF BCP 47 language tag".
Bundle.main.preferredLocalizations.first will return a matching code on CFBundleLocalizations if there is one, which is usually a 2 letter code, or if there isn't one that matches, then it will return the CFBundleDevelopmentRegion, which is a 2 or 3 letter ISO code. So I don't think the getAppLanguageTag method is needed, and also, I don't think the getAppLanguageCode should return a 2 letter code as it could also be a 3 letter ISO code.
I think it should just be getAppLanguage() and return the whole value of Bundle.main.preferredLocalizations.first

IT-MikeS
IT-MikeS suggested changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@IT-MikeS IT-MikeS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see jcesarmobile's comment above.

@ThatOneCalculator
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IT-MikeS IT-MikeS Awaiting requested review from IT-MikeS

@markemer markemer Awaiting requested review from markemer

@jcesarmobile jcesarmobile Awaiting requested review from jcesarmobile

@theproducer theproducer Awaiting requested review from theproducer

@ItsChaceD ItsChaceD Awaiting requested review from ItsChaceD

@giralte-ionic giralte-ionic Awaiting requested review from giralte-ionic

Assignees
No one assigned
Labels
pr review requested Adds PR to internal issue tracker for team review type: feature request A new feature, enhancement, or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@philet @jcesarmobile @ThatOneCalculator @IT-MikeS @dallastjames